Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent sample files showing up in the TV shows area of Media Library #3978

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SubJunk
Copy link
Member

@SubJunk SubJunk commented Jul 7, 2023

No description provided.

@SubJunk SubJunk requested a review from a team July 7, 2023 21:03
@SurfaceS
Copy link
Contributor

I think this one should not be merged now.

My next PR will remove video track info from FILES table, and move it to VIDEOTRACKS table.

Also, filtering on a "greater than double value" is maybe not the best way to do.

Sample can be a flag on VIDEO_METADATA table, like the ISTVEPISODE one (ISSAMPLE, or ISTRAILER).

@SubJunk
Copy link
Member Author

SubJunk commented Jul 28, 2023

@SurfaceS cool, I agree. It is potentially still a good index to add here https://github.com/UniversalMediaServer/UniversalMediaServer/pull/3978/files#diff-552ef7c3f32721c1801d78dd004a1f15a637b21e22215c79192b3b8ed552bffeR467 because we already filter by duration for movies. Or we could add an isMovie boolean and start using that

@SubJunk SubJunk removed the request for review from a team July 28, 2023 19:37
@UniversalMediaServer UniversalMediaServer deleted a comment from github-actions bot Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants