Add custom FFmpeg Audio options #1323

Sami32 · 2017-06-26T15:10:39Z

As requested here: #1181 #1179

onon765trb · 2017-06-30T09:57:24Z

GJ!!!

Sami32 · 2017-06-30T22:15:43Z

@ler0y In your case adding these lines to your renderer configuration file will reduce transcoding to WAV having a sample rate < 48000:

TranscodeAudio = WAV
CustomAudioFFmpegOptions = -af aformat=sample_fmts=u8|s16:sample_rates=44100|48000

Fine tune it to your renderer support. Ex. 96000 if it's DTS is supported in WAV.

P.S. You can also use the -apre option, more powerful, but it also ask more modifications from the user side.

SubJunk

Good start but needs a bit more work

SubJunk · 2017-07-25T16:00:43Z

src/main/external-resources/renderers/DefaultRenderer.conf

+# Overrides the FFmpeg Audio options in UMS for this renderer.
+# An empty value means that the default UMS settings will be used.
+# Default: ""
+CustomAudioFFmpegOptions =


It would be good to rename this to CustomFFmpegAudioOptions to match our other conventions

I agree. I should admit that i saw it afterward and was too lazzy to change it.

SubJunk · 2017-07-25T16:00:58Z

src/main/java/net/pms/configuration/RendererConfiguration.java

@@ -2262,6 +2263,10 @@ public int getAutoPlayTmo() {
 		return getInt(AUTO_PLAY_TMO, 5000);
 	}

+	public String getCustomAudioFFmpegOptions() {


SubJunk · 2017-07-25T16:01:20Z

src/main/java/net/pms/encoders/FFmpegAudio.java

@@ -142,7 +144,7 @@ public synchronized ProcessWrapper launchTranscode(
 		configuration = (DeviceConfiguration)params.mediaRenderer;
 		final String filename = dlna.getFileName();
 		params.maxBufferSize = configuration.getMaxAudioBuffer();
-		params.waitbeforestart = 2000;
+		params.waitbeforestart = 1;


Why change this?

No waiting delay while playing music.
Tested by us without any issues since some months, also with my very old CPU.
If i remember correctly, we are talking about 100MB to be buffereized in 2s, it seem out of age, also for me.

SubJunk · 2017-07-25T16:02:23Z

src/main/java/net/pms/encoders/FFmpegAudio.java

@@ -200,30 +202,53 @@ public synchronized ProcessWrapper launchTranscode(
 			cmdList.add("" + params.timeend);
 		}

+		String customAudioFFmpegOptions = params.mediaRenderer.getCustomAudioFFmpegOptions();
+
+		// Add audio options (-af, -filter_complex, -ab, -ar, -ac, -c:a, -f, -apre, -fpre, -pre, etc.)


This comment could probably be put into DefaultRenderer.conf too

SubJunk · 2017-07-25T16:08:09Z

src/main/java/net/pms/encoders/FFmpegAudio.java

@@ -247,6 +272,44 @@ public synchronized ProcessWrapper launchTranscode(
 		return pw;
 	}

+	/**


Since these are already in FFmpegVideo which this extends, we shouldn't need to add them again unless they are different from those ones, in which case the @override flag should be present

Damned Github, i cannot see anything except /**

Please, feel free to push a commit using an @override flag, if the changes done are not correct, as i could learn from it for an eventual next time.

@Sami32 I just checked and those parseOptions methods are identical to the ones in FFmpegVideo except for comment changes in the second one, so it would be better to remove those from this file and if you want, make the comment changes in FFmpegVideo. Otherwise it's just writing the same code twice which also means bugfixes need to get written twice, etc.

I agree that doesn't use the same code twice will be good.

But, just to be clear, when i do the changes asked and that errors arise, i just stop brutally to be interested...
So, or you push a commit, or this PR will wait until my mood become better...

@Sami32 "when i do the changes asked" you didn't do the changes asked. I said to add @override if the methods are different otherwise we shouldn't need to add them, and they are not different.

Up to you whether you implement the changes or not :)

SubJunk · 2017-07-25T19:59:13Z

src/main/java/net/pms/encoders/FFmpegAudio.java

@@ -247,6 +272,44 @@ public synchronized ProcessWrapper launchTranscode(
 		return pw;
 	}

+	/**


@Sami32 I just checked and those parseOptions methods are identical to the ones in FFmpegVideo except for comment changes in the second one, so it would be better to remove those from this file and if you want, make the comment changes in FFmpegVideo. Otherwise it's just writing the same code twice which also means bugfixes need to get written twice, etc.

Sami32 changed the title ~~Add audio custom FFmpeg options~~ Add custom FFmpeg Audio options Jun 26, 2017

Sami32 added the awaiting review label Jun 26, 2017

Sami32 force-pushed the audio_ffmpeg_custom branch from 4694d8b to 1e98d4f Compare June 26, 2017 15:49

Sami32 mentioned this pull request Jul 10, 2017

Update some renderer's configuration #1320

Closed

Sami32 force-pushed the audio_ffmpeg_custom branch 2 times, most recently from 9647fbd to 90adb4e Compare July 13, 2017 22:25

SubJunk requested changes Jul 25, 2017

View reviewed changes

Sami32 force-pushed the audio_ffmpeg_custom branch 2 times, most recently from 747e978 to bd72934 Compare July 25, 2017 18:04

SubJunk requested changes Jul 25, 2017

View reviewed changes

SubJunk removed the awaiting review label Jul 25, 2017

Sami32 force-pushed the audio_ffmpeg_custom branch 2 times, most recently from 22bee6e to c8d5fb9 Compare July 27, 2017 01:24

Add audio custom FFmpeg options

c8d5fb9

Sami32 added the enhancement label Jul 27, 2017

valib added this to To do in Universal Media Server May 28, 2020

Merge branch 'master' into audio_ffmpeg_custom

775064d

github-actions bot added the conflicting label Jan 18, 2024

UniversalMediaServer deleted a comment from github-actions bot Jan 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add custom FFmpeg Audio options #1323

Add custom FFmpeg Audio options #1323

Sami32 commented Jun 26, 2017 •

edited

onon765trb commented Jun 30, 2017

Sami32 commented Jun 30, 2017 •

edited

SubJunk left a comment

SubJunk Jul 25, 2017

Sami32 Jul 25, 2017

SubJunk Jul 25, 2017

SubJunk Jul 25, 2017

Sami32 Jul 25, 2017

SubJunk Jul 25, 2017

SubJunk Jul 25, 2017

SubJunk Jul 25, 2017

Sami32 Jul 25, 2017 •

edited

SubJunk Jul 25, 2017

Sami32 Jul 25, 2017 •

edited

SubJunk Jul 26, 2017 •

edited

SubJunk Jul 25, 2017

Add custom FFmpeg Audio options #1323

Are you sure you want to change the base?

Add custom FFmpeg Audio options #1323

Conversation

Sami32 commented Jun 26, 2017 • edited

onon765trb commented Jun 30, 2017

Sami32 commented Jun 30, 2017 • edited

SubJunk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sami32 Jul 25, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sami32 Jul 25, 2017 • edited

Choose a reason for hiding this comment

SubJunk Jul 26, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sami32 commented Jun 26, 2017 •

edited

Sami32 commented Jun 30, 2017 •

edited

Sami32 Jul 25, 2017 •

edited

Sami32 Jul 25, 2017 •

edited

SubJunk Jul 26, 2017 •

edited