Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mediawiki/mediawiki-codesniffer requirement from 41.0.0 to 43.0.0 #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2024

Updates the requirements on mediawiki/mediawiki-codesniffer to permit the latest version.

Changelog

Sourced from mediawiki/mediawiki-codesniffer's changelog.

43.0.0 / 2024-01-29

New sniffs

  • Added the following sniffs from the PHPCSExtra standards: (Daimona Eaytoy)
    • Universal.Constants.LowercaseClassResolutionKeyword: Enforce lowercase ::class
    • Universal.Constants.UppercaseMagicConstants: Enforce uppercase magic constants
    • Universal.ControlStructures.DisallowAlternativeSyntax: Disallow alternative PHP syntax
    • Universal.Lists.DisallowLongListSyntax: Disallow the long list()syntax
    • Universal.Operators.TypeSeparatorSpacing: Forbid spaces in union and intersection types
    • Universal.UseStatements.KeywordSpacing: Enforce a single space around keywords in use statements
    • Universal.UseStatements.LowercaseFunctionConst: Enforce lowercase function and const in use statements
    • Universal.UseStatements.NoUselessAliases: Forbids aliases in use statements where the alias is the same as the original name
    • Universal.WhiteSpace.CommaSpacing: Enforce correct spacing around commas

Changed sniffs

  • DeprecatedGlobalVariablesSniff: Add $wgCommandLineMode (Bartosz Dziewoński)
  • FunctionCommentSniff & PropertyDocumentationSniff: Allow array shapes in PHPDoc comments (thiemowmde)
  • FunctionCommentSniff: Require documentation of getters starting with "is", not only "get" (thiemowmde)
  • FunctionCommentSniff: Actually check if a method returns anything (thiemowmde)
  • FunctionAnnotationsSniff: Add @phan-type as an allowed annotation (Umherirrender)
  • FunctionAnnotationsSniff: Add @phan-side-effect-free as an allowed annotation (Bartosz Dziewoński)
  • LowerCamelFunctionsNameSniff: Ignore hook methods (DannyS712)
  • PhpunitAnnotationsSniff: Enforce absolute class path for coverage annotations (Func)

Removed sniffs

  • OneSpaceInlineArraySniff: Superseded by Universal.WhiteSpace.CommaSpacing
  • ShortListSyntaxSniff: Superseded by Universal.Lists.DisallowLongListSyntax
  • AlternativeSyntaxSniff: Superseded by Universal.ControlStructures.DisallowAlternativeSyntax

Documentation, dependencies and build changes

  • Run in parallel with 64 jobs by default (Kunal Mehta, Antoine Musso)
  • build: Allow composer/semver 3.4.0 as well as 3.3.2 (Reedy)
  • tests: Add test for awfully inconsistent code (Daimona Eaytoy)
  • build: Update squizlabs/PHP_CodeSniffer to 3.8.1 (Umherirrender)

42.0.0 / 2023-09-21

New sniffs

  • Create MockBoilerplateSniff for PHPUnit tests (DannyS712)
  • Create OneSpaceInlineArraySniff (Amir Sarabadani)
  • Create ShortListSyntaxSniff to replace list() by short array syntax (Umherirrender)
  • Enable Generic.WhiteSpace.ScopeIndent (Daimona Eaytoy)
  • Enable Squiz.ControlStructures.ControlSignature (Daimona Eaytoy)
  • Replace AssignmentInControlStructuresSniff with Generic.CodeAnalysis.AssignmentInCondition (Daimona Eaytoy)
  • Replace DisallowEmptyLineFunctionsSniff with Squiz.WhiteSpace.FunctionOpeningBraceSpace (Daimona Eaytoy)

Changed sniffs

  • AssertCountSniff: Prefer assertSameSize when both parts are count() (Func)
  • DeprecatedGlobalVariablesSniff: Add $wgHooks (Umherirrender)
  • ForbiddenFunctionsSniff: Fix not counting arguments correctly (Daimona Eaytoy)
  • SpaceAfterClosureSniff: Expand to enforce space after arrow functions (Umherirrender)

... (truncated)

Commits
  • c559bc0 HISTORY: Mark this as v43.0.0
  • 0ba5905 HISTORY: Add blended entry for 5351ea927 and 6927784cf
  • 645429d HISTORY: Add entry for 4861986b0
  • caeab67 HISTORY: Add entry for 9640c3255
  • 6927784 build: Update squizlabs/php_codesniffer to 3.8.1
  • 8c9cb70 Enforce absolute class path for coverage annotations
  • 4861986 composer.json: Allow newer composer/semver
  • 5351ea9 build: Update squizlabs/php_codesniffer to 3.8.0
  • 9640c32 Deprecate $wgCommandLineMode
  • 8b4eb65 LowerCamelFunctionsNameSniff: Ignore hook methods
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 1, 2024
@Universal-Omega
Copy link
Owner

@dependabot recreate

Updates the requirements on [mediawiki/mediawiki-codesniffer](https://github.com/wikimedia/mediawiki-tools-codesniffer) to permit the latest version.
- [Changelog](https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/HISTORY.md)
- [Commits](wikimedia/mediawiki-tools-codesniffer@v41.0.0...v43.0.0)

---
updated-dependencies:
- dependency-name: mediawiki/mediawiki-codesniffer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/composer/mediawiki/mediawiki-codesniffer-43.0.0 branch from 82b1946 to cd22e03 Compare May 16, 2024 23:58
Copy link

coderabbitai bot commented May 16, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant