Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Nix flake #421

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add Nix flake #421

wants to merge 5 commits into from

Conversation

lavafroth
Copy link
Contributor

Related to #43

  • Adds a flake.nix file which describes all the dependencies and outputs a dev shell where Nix users can build uadng.
  • Adds a flake.lock file to pin the dependencies to tested versions.

@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Apr 13, 2024 •
edited

Here's the code health analysis summary for commits 8df133c..1adf69b. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@AnonymousWP AnonymousWP changed the title Add Nix flake feat: add Nix flake Apr 13, 2024
@AnonymousWP AnonymousWP added enhancement New feature or request dependencies Pull requests that update a dependency file labels Apr 13, 2024
@AnonymousWP AnonymousWP requested a review from a team April 13, 2024 11:45
@lavafroth lavafroth mentioned this pull request Apr 14, 2024
Merged
@adhirajsinghchauhan adhirajsinghchauhan added the help wanted Extra attention is needed label Apr 14, 2024
edgy-b
edgy-b reviewed May 1, 2024
View reviewed changes
Copy link
Contributor

@edgy-b edgy-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure who's gonna maintain this in case there are errors/updates etc.

flake.nix
clang
pkg-config
mold
expat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with Nixos, but why it needs XML parser lib?
https://libexpat.github.io/

flake.nix
pkgs.xorg.libXcursor
pkgs.xorg.libXi
pkgs.xorg.libXrandr
pkgs.libxkbcommon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, not sure why it needs this? Some X11 dep without it won't run?

@lavafroth
Copy link
Contributor Author

lavafroth commented May 1, 2024 via email

@lavafroth
Copy link
Contributor Author

lavafroth commented May 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgy-b edgy-b edgy-b left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lavafroth @edgy-b @adhirajsinghchauhan @AnonymousWP