Added check for managed stack frame #1298
Conversation
…ializer-fix Fix serialization issue with DataContractJsonSerializer UseSimpleDictionaryFormat (case 1070667)
…dfile-blocking Fix interrupting blocking file IO on Windows.
…etthreadcontext Bump bdwgc submodule to get fix for GetThreadContext (case 1114668)
…le-grow Update bdwgc
Upgrade automake to 1.16.1
Change stevedore repo to public
…8285 Break out of outter loop once file is found. (case 1118285)
…9657 [corlib] Allow DM with an extra param to have the first one bound to …
The format string was incorrect in this case, which leads to this crash in Unity: https://crashes.hq.unity3d.com/crashes/5aa00d01b4db11000de20c8e?versions_range=2018.3.5..2019.2.99&date_start=&date_end=&source= Simply remove the unused `%s` format specifier here.
Fix warning crash
…ontext OS synchronization context
Update to latest bee (be3d27e00f2f)
Use bokken runner for windows builds
Add Yamato configs
…edore Remove old mono artifact
…loffset-to-stepevent Add iloffset to stepevent
Changes to use artifacts from stevedore unity-internal
* When we try to call a method to get the async_id to do an async debug and we are trying to do this in a generic method like this:
async Task<T> ExecuteAsync_Broken<T>()
{
await Task.Delay(2);
return default;
}
We need to inflate the generic type before call the method or we will get the error: Could not execute the method because the containing type 'System.Runtime.CompilerServices.AsyncTaskMethodBuilder1[T_REF]’, is not fully instantiated.
Fixes mono#17549
Fixes mono#17569
Cherry-picked by Alex Thibodeau -- some light massaging required
* Removing some asserts and returning err_invalid_argument with an error message when it's possible. * if we don't find method get_ObjectIdForDebugger we try to find the property Task to continue async debug. Cherry-picked by Alex Thibodeau with some moderate changes
Publish mbe to unity-internal
…1280 mono debugger remove some asserts and fixing an error for async debug of a generic (fixes case 1241280)
…1344 Adding check to avoid processing pdbs that have zero sequence points …
…5903 [runtime] Magic interfaces requires the complex stelemref to handle a…
|
@scott-ferguson-unity note this is the file in the Mono repo. There is a copy in the IL2CPP repo. |
|
I assumed everything in This PR won't hurt anything, but should I take out the case number since landing this won't fix the case? |
|
@scott-ferguson-unity case number is fine to leave in. |
Doesn't this correct case 1250002? I confused. Also, should we back port this fix? |
* update bdwgc * Expose mono_gc_start_incremental_collection API * switch bdwgc repo back to unity-master branch
…-array-marking-stack-limit Avoid exceeding the mark stack limit (case 1235202)
Ensure we have an managed stack frame before access.
scott-ferguson-unity
force-pushed
the
unity-master-fix-1250002
branch
from
7747b05
to
a84f341
Compare
scott-ferguson-unity
changed the title
|
This PR doesn't actually fix 1250002, since the user's issue as a bug in VS2019. I've landed a fix in the IL2CPP repo for this crash. Do we need to make the same change here? Is there any reason to backport it? |
|
|
Ensure we have a managed stack frame before access.