update dependencies to newer versions for sprawl compatibility #146
Conversation
|
one note: i have not done any additional testing for cloud training and storage, &c. |
pyproject.toml
Outdated
| @@ -26,10 +26,10 @@ include = [ | |||
| [tool.poetry.dependencies] | |||
| python = "^3.7" | |||
| cython = "^0.29.14" | |||
| google-cloud-storage = ">=1.24.1 <=1.28.1" | |||
| google-cloud-storage = ">=1.31.1" | |||
There was a problem hiding this comment.
I am assuming this issue was fixed in `google-cloud-storage 1.31+?
There was a problem hiding this comment.
i did not know about that issue. it looks like 1.31.1 merged those changes. we could do a later version if that matters, but i picked this to align with what sprawl uses currently
release notes for the fix: https://github.com/googleapis/python-storage/releases/tag/v1.31.1
blob: base64 includes additional characters
There was a problem hiding this comment.
Good to know the issue is fixed. Let's also include <2.0.0 in the requirements to make sure we don't accidentally bump the major version.
pyproject.toml
Outdated
| jupyter = "^1.0.0" | ||
| kornia = "^0.1.4" | ||
| numpy = ">=1.17 < 1.18" | ||
| numpy = ">=1.18.2" |
There was a problem hiding this comment.
Let's use ^1.18.2 or >=1.18.2 <2.0.0 (they are equivalent syntex). This prevents unexpected major version bump.
There was a problem hiding this comment.
ah, good call! making that update.
Peer Review Information
upgraded
google-cloud-storageto >=1.31.1 andnumpyto >=1.18.2Pull Request Check List
no new tests or documentation.