Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ClientDriven further Netcode for GameObjects v1.8.1 API upgrades [MTT-8543] #173

Merged

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented May 6, 2024

Description

This PR upgrades in one call site to the usage of NetworkObject.InstantiateAndSpawn() API.
It is clarified in another place in code how to use this code in conjunction with a NetworkObject with Rigidbody Interpolation enabled.

Included in this PR is a fix to the ServerIngredientSpawner script such that it:

  • is disabled as soon as NetworkManager is not listening
  • can function normally in the case that a client disconnects and wants to host a session again (it would be disabled and never re-enabled before)

Issue Number(s)

MTT-8543

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez added the enhancement New feature or request label May 6, 2024
@fernando-cortez fernando-cortez changed the title feat: ClientDriven further Netcode for GameObejcts v1.8.1 API upgrades feat: ClientDriven further Netcode for GameObejcts v1.8.1 API upgrades [MTT-8543] May 8, 2024
@fernando-cortez fernando-cortez marked this pull request as ready for review May 8, 2024 16:55
@fernando-cortez fernando-cortez requested a review from a team as a code owner May 8, 2024 16:55
@fernando-cortez fernando-cortez merged commit f2e33e9 into develop May 13, 2024
19 checks passed
@fernando-cortez fernando-cortez deleted the feat/clientdriven-further-NGOv1.8.1-API-upgrades branch May 13, 2024 19:07
@fernando-cortez fernando-cortez changed the title feat: ClientDriven further Netcode for GameObejcts v1.8.1 API upgrades [MTT-8543] feat: ClientDriven further Netcode for GameObjects v1.8.1 API upgrades [MTT-8543] May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants