Direct IP connection UI #116
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,6 +10,10 @@ namespace Unity.Netcode.Samples.APIDiorama.Common | |||
|
|
|||
| public class NetworkManagerUI : MonoBehaviour | |||
| { | |||
| static readonly Regex s_IPRegex = new Regex("\\b(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)(\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)){3}\\b"); | |||
There was a problem hiding this comment.
UTP has NetworkEndpoint.TryParse which returns whether it was successful or not, might be worth using that instead of custom implementation.
There was a problem hiding this comment.
oh nice, I didn't know it! Will do
3 tasks
|
marking as draft as this was done before the UI conversion to UITK, so the UI part must be redone, see https://jira.unity3d.com/browse/MTT-7497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[UI] Added possibility to specify the IP address of the server you want to connect to
Format of IP address is automatically checked whenever the user finishes writing it
Contribution checklist
[ ] Tests have been added for the project and/or any internal packageN/A[ ] Release notes have been added to the project changelog fileN/A[ ] JIRA ticket ID is in the PR title or at least one commit messageN/A[ ] Include the ticket ID number within the body message of the PR to create a hyperlinkN/A