Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stadia from runtime asmdef (WIP) #598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

windxu88
Copy link
Contributor

Purpose of this PR

Remove Stadia from runtime asmdef which should fall through the crack when working on ABC-393.

Ticket/Jira #:
ABC-393 warning 'BuildTarget.Stadia' is obsolete: 'Stadia has been removed in 2023.1' when loading Alembic package from disk

Testing

Functional Testing status:

Performance Testing status:

Overall Product Risks

Complexity:

Halo Effect:

Documentation & UX Writing

User facing text to review Details
User interface
Public API docs
Changelog
Documentation halo effect Jira link
User manual
Other docs

Additional information

Note to reviewers:

Reminder:

  • Add entry in CHANGELOG.md

@windxu88 windxu88 requested a review from thomas-tu April 19, 2024 18:14
@windxu88 windxu88 changed the title Remove stadia from runtime asmdef Remove stadia from runtime asmdef (WIP) Apr 19, 2024
@windxu88 windxu88 requested review from thomas-tu and removed request for thomas-tu April 19, 2024 18:58
@windxu88
Copy link
Contributor Author

windxu88 commented Apr 19, 2024

@thomas-tu , Test version 2019.4 on win job fails with following error:

Failed - "API Validation"
    Error: Removing from includePlatfoms requires a new major version. Was:"Editor, LinuxStandalone64, macOSStandalone, Stadia, WindowsStandalone64" Now:"Editor, LinuxStandalone64, macOSStandalone, WindowsStandalone64"

    The above error can be excepted with the following ValidationExceptions.json contents:
{

The error can be exempted.

However, considering this is a trival change. If we leave Stadia in the asmdef file, users won't see any difference. Maybe we give up doing this?

Note: The API validation job failures are noises, unrelated to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant