[Abc492] Handle Attribute Interpolation for Curves #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix commit
* First pass to extract redundant code and have one single template function * Use templates in other parts of aiMeshSchema to handle custom attributes. * Fix post-merge issues * Add specific supports for IC3f and IN4f attributes * Remove test code * Remove unused includes
…nologies/com.unity.formats.alembic into ABC483-Support-curves # Conflicts: # Source/abci/Importer/aiCurves.cpp # Source/abci/Importer/aiCurves.h # Source/abci/Importer/aiMeshSchema.h
…nologies/com.unity.formats.alembic into ABC483-Support-curves # Conflicts: # Source/abci/Importer/aiCurves.h
… ABC483-Support-curves # Conflicts: # Source/abci/Importer/AlembicImporter.h # Source/abci/Importer/aiMeshSchema.h # com.unity.formats.alembic/Runtime/Scripts/Importer/AbcAPI.cs # com.unity.formats.alembic/Runtime/Scripts/Importer/AlembicMesh.cs
…ve-interpolation # Conflicts: # Source/abci/Foundation/aiMath.cpp # Source/abci/Foundation/aiMath.h # Source/abci/Importer/aiCurves.cpp
Base automatically changed from
ABC483-Support-curves
to
dev/feature/custom-attributes
February 22, 2024 20:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ticket/Jira #:ABC-492
This PR handles the interpolation of custom attributes for the curves.
Testing
Functional Testing status:
Manual testing using the following asset : curve_2points_animatedColor_24fps_0-24f (1).zip
Use the following patch for debugging : com.unity.formats.alembic-18-37-39.patch
This sets the color of the asset's material to the color attribute (that is changing). This facilitates the debugging as you can see the result directly without break points.
readAttribute.mp4