New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGE: added more information in the dialog to restart the editor. #1913
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This small clarification looks good to me. I would however add @duckets as a reviewer on this PR since he is the technical writer on the team and can support in following language and communication consitency guidelines for this kind of user feedback. Include @duckets as reviewer on anything involving dialogs, UI text, public API docs or manual updates.
I will request changes though since the CHANGELOG.md file needs to be updated with a notice under the Changed header about this modification (even if non-functional it makes sense to include it and to get into process with this PR). Also changelog entry should link the public URL of the bug issue for convenience (see existing examples).
In addition the PR is in draft status, you should convert it into a regular PR if there are no further changes planned on it. We typically use drafts only to get some feedback when work is pending / not finished. |
I also see you need to sign the license/CLA for CI to pass on this one. This is a one time thing you need to do to contribute to the repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, two things:
|
Description
When the editor is restarted, pending import operations and windows are closed. The dialog has added information to inform the user of this. ISXB-608
Changes made
Modified dialog text.
Checklist
Before review:
Changed
,Fixed
,Added
sections.([case %number%](https://issuetracker.unity3d.com/issues/...))
.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.