Ledger connector #877
Open
Ledger connector #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JFrankfurt
reviewed
Sep 14, 2023
Comment on lines
+90
to
+91
| const src = "https://statuesque-naiad-0cb980.netlify.app/umd/index.js"; | ||
| const globalName = "ledgerConnectKit"; |
There was a problem hiding this comment.
if you need a package you should load it via yarn
There was a problem hiding this comment.
This is an architecture decision that was made to enable hot upgrades on the connect kit.
Unfortunately, falling back to a package manager solution is not a change we can implement at the moment.
There was a problem hiding this comment.
if you need a package you should load it via yarn
Hero of the day sir, thanks for the common sense you showed on that sweet September 14
There was a problem hiding this comment.
This brings so much joy to my cold dead security heart that you spotted this and blocked merging because of it, saving many!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test it locally :
./
yarn && yarn buildAdd this dependency in exemple/package.json :
"@web3-react/ledger": "file:../packages/ledger",./exemple
pnpm i && pnpm start