Showcase: Transient support in the compiler #541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This is amazing but closing! We can reopen if they decide to merge it into the compiler 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on a branch of the compiler that supports the transient keyword
This is nowhere near production ready, but this commit is able to process the uniswap-v4-core codebase (with minor changes).
Description of changes
I had to remove theFixed.using xxx for mapping(...);which cause issues in my branch. IMO this is minor.Lock.solandNonZeroDeltaCount.sollibraries in favor of transient variables declared inPoolManager.soldirectlycurrencyDeltaas a transient mapping.Unfortunatelly, I don't expect this version of the compiler to be available anytime soon. But I want to show that its possible, that tests pass, and that gas usage looks good!