Add differentiation between LTS and non-LTS builds #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
|
Great, it works |
|
THIS GIT WORKS WITH THE LATEST ANTON BLAST DEMO!!! |
|
W pull request |
Miepee
reviewed
May 22, 2024
| /// <summary> | ||
| /// The GameMaker release branch of the data file. May be set to "NonLTS" when features exempted from LTS are detected. | ||
| /// </summary> | ||
| public BranchType Branch = BranchType.LTS; |
There was a problem hiding this comment.
any reason why we have lts as default instead of nonlts?
There was a problem hiding this comment.
Non-LTS is detected when we find a feature that isn't present on LTS, and there's no point setting the default to "LTS if it's at least the earliest version for which LTS exists" because there are no checks for LTS-ness on older versions.
There was a problem hiding this comment.
hmm, IMO it just comes off as confusing if i load a game that was made before lts existed and it shows as LTS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the end of October 2022, the GameMaker versions were split into two: LTS and non-LTS. This marked the beginning of the era called "UndertaleModTool breaking for the 400th time".
This PR adds a Branch enum value to GeneralInfo which can be used to differentiate between these versions without causing confusion with
UndertaleData.IsVersionAtLeast()(as actually setting the version to 2022.0 would indicate being much older than many of the features therein). It also adds some methods to interact with this, one beingUndertaleData.IsNonLTSVersionAtLeast(), and implements its usage in regards to Particle Systems and Spine Sprites, both of which are not present on the current LTS despite other fixes. Closes #1703, closes #1729.Caveats
Using an enum is theoretically extensible for other branches, but that seems improbable. More likely we'll just get 2024.0 and have to adjust around that; mostly I just don't want to go back to version booleans. The
UndertaleData.SetLTS()method is also weird (boolean input), and this all renders the estimated version in the window title completely off. Oh, and it can't be set through the GUI.Notes
Due to all the caveats (and wanting further input on how to resolve them), I'm marking this as draft.