Second-pass asset resolution #1689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
…UndertaleModTool into switch-case-resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a second pass to asset resolution following high-level decompilation, which can identify and resolve switch cases past the first. Closes #1374.
Caveats
Limited testing has been performed. Improves asset resolution on 22 code entries of Undertale v1.08, but has slight errors on 2 others: incorrectly resolving
obj_woshua.mycommandas a boolean due to a strangeif mycommandcheck, and removing the accurate boolean resolution fromselected2inscr_namingscreenbecause the correct resolution was a happy accident of the way resolution was implemented. Speed has also not been tested.Notes
N/A