Clickable code search results line numbers. #1579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladiStep
force-pushed
the
clickableCodeLineNumbers
branch
from
54a7131
to
2029263
Compare
|
Download the artifacts for this pull request here: GUI:
CLI: |
VladiStep
force-pushed
the
clickableCodeLineNumbers
branch
from
2029263
to
424d807
Compare
Miepee
reviewed
Dec 24, 2023
|
|
Miepee
approved these changes
Jan 11, 2024
| @@ -298,25 +305,25 @@ private async void UserControl_DataContextChanged(object sender, DependencyPrope | |||
| CurrentDecompiled = null; | |||
| CurrentDisassembled = null; | |||
|
|
|||
| if (MainWindow.CodeEditorDecompile != Unstated) //if opened from the code search results "link" | |||
| if (EditorTab != CodeEditorTab.Unknown) // if opened from the code search results "link" | |||
There was a problem hiding this comment.
please use Uppercase If in comment.
| int totalLineCount = resultsDict.Select(x => x.Value.Count).Sum(); | ||
| bool tooManyLines = totalLineCount > 10000; | ||
| if (tooManyLines) | ||
| mainWindow.ShowWarning($"There are too many code lines to display ({totalLineCount}), so there would be no clickable line numbers."); |
There was a problem hiding this comment.
Suggested change
| mainWindow.ShowWarning($"There are too many code lines to display ({totalLineCount}), so there would be no clickable line numbers."); | |
| mainWindow.ShowWarning($"There are too many code lines to display ({totalLineCount}), so no clickable line numbers are shown."); |
There was a problem hiding this comment.
Hmm, what if "...so the line numbers won't be clickable."?
There was a problem hiding this comment.
"won't" (will not) is future. you want present though.
Whether you use "so the line numbers aren't clickable" or "so no clickable line numbers are shown" doesnt really matter for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CodeEditorDecompile) and enum (CodeEditorMode) out from theMainWindow, and also renamed them.overwriteargument forTab.SaveTabContentState().Fixes #1580.