Revise for audio, texture, globalinit #1520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
VladiStep
reviewed
Nov 14, 2023
VladiStep
reviewed
Nov 15, 2023
| @@ -29,7 +31,7 @@ public void Serialize(UndertaleWriter writer) | |||
| public void Unserialize(UndertaleReader reader) | |||
| { | |||
| _code = new UndertaleResourceById<UndertaleCode, UndertaleChunkCODE>(); | |||
| _code.Unserialize(reader); // TODO: reader.ReadUndertaleObject if one object starts with another one | |||
There was a problem hiding this comment.
i have not tested it, but considering that ReadUndertaleObject(T obj) ends up also doing obj.Unserialize() it seemed fine to me.
I don't have any games that use global init to double check it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slightly improves documentation
Removes default values