Pack System.Xaml also in debug #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I dont know why it was packed only in Release, I lost an hour trying to figure out what is wrong when building Studio with a local version of CoreWF. When using a locally built CoreWF package, Studio build gives a whole lot of strange errors because System.Xaml.dll is missing from net6 lib in package
pawelpopielarski
requested review from
aoltean16 and
gabriela-lungu-uip
as code owners
aoltean16
approved these changes
May 10, 2024
|
let's wait robot input here. |
gabriela-lungu-uip
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dont know why it was packed only in Release,
I lost an hour trying to figure out what is wrong when building Studio with a local version of CoreWF.
When using a locally built CoreWF package, Studio build gives a whole lot of strange errors because
System.Xaml.dllis missing from net6 lib in package