[ROBO-3381] split and merge poc #306
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihainradu
changed the title
mihainradu
force-pushed
the
feature/mr-bpm-playground
branch
5 times, most recently
from
a09d674
to
bb5a103
Compare
mihainradu
force-pushed
the
feature/mr-bpm-playground
branch
from
556ff81
to
52cf89e
Compare
mihainradu
force-pushed
the
feature/mr-bpm-playground
branch
7 times, most recently
from
edee40b
to
353521f
Compare
mihainradu
force-pushed
the
feature/mr-bpm-playground
branch
5 times, most recently
from
5a81556
to
9b8139c
Compare
mihainradu
force-pushed
the
feature/mr-bpm-playground
branch
from
aa6c8e5
to
bb3e9f5
Compare
danutboanta
reviewed
Apr 15, 2024
Comment on lines
162
to
167
| HashSet<FlowMerge> allMerges = new(); | ||
| foreach (var branch in split.Branches) | ||
| { | ||
| var merges = GetMerges(branch).Distinct().ToList(); | ||
| allMerges.AddRange(merges); | ||
| } |
There was a problem hiding this comment.
You can simplify by getting all the merges for a split, e.g.:
var allMerges = GetMerges(split)
and GetMerges can be:
List<FlowMerge> GetMerges(FlowSplit flowSplit) { return ( from nodeInfo in _staticBranchesByNode where nodeInfo.Key is FlowMerge where nodeInfo.Value.GetTop().Contains(flowSplit) select nodeInfo.Key as FlowMerge ).ToList(); }
| SourceDetail = new[] { node }.Concat(otherNodes ?? Array.Empty<FlowNode>()).ToArray() | ||
| }); | ||
| } | ||
| List<FlowMerge> GetMerges(FlowNode flowNode) |
There was a problem hiding this comment.
Change to return the merges for a split
| AddStack(preStacks.SplitsStack); | ||
| } | ||
|
|
||
| private void AddStack(List<List<FlowSplit>> stack) |
| } | ||
|
|
||
| private bool HasStack(List<FlowSplit> stack) | ||
| => SplitsStack.Any(b => stack.Count == b.Count && stack.All(p => b.Contains(p))); |
There was a problem hiding this comment.
=> SplitsStack.Any(s => s.SequenceEqual(stack));
| private bool HasStack(List<FlowSplit> stack) | ||
| => SplitsStack.Any(b => stack.Count == b.Count && stack.All(p => b.Contains(p))); | ||
|
|
||
| internal bool IsOnStack(StaticNodeStackInfo toConfirm) |
There was a problem hiding this comment.
Not needed, if you rewrite the GetMerges method
|
|
||
| public void AddPop(StaticNodeStackInfo popFrom) | ||
| { | ||
| var result = popFrom.SplitsStack.Select(s => Enumerable.Reverse(s).Skip(1).Reverse().ToList()).ToList(); |
| return new (SplitsStack.Select(b => b.LastOrDefault())); | ||
| } | ||
|
|
||
| public void Push(FlowSplit newSplit, StaticNodeStackInfo splitsStackInfo) |
| Fx.Assert(completedInstance != null, "cannot request cancel if we never scheduled any children"); | ||
| // we are done but the last child didn't complete successfully | ||
| if (completedInstance.State != ActivityInstanceState.Closed) | ||
| if (WasVisited(current)) |
There was a problem hiding this comment.
WasVisited is based on node.Flowchart != null.
I did not understand if the new nodes are created every time before CacheMetadata
mihainradu
force-pushed
the
feature/mr-bpm-playground
branch
6 times, most recently
from
531bdcd
to
8b65fa6
Compare
mihainradu
force-pushed
the
feature/mr-bpm-playground
branch
from
7f54cf0
to
1247d51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.