Improve first invoke performance #260
Open
+132
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first `Invoke()` call is slow. When the xaml file contains a lot of VB scripts, JIT compiler will be used, but for **every** compilation, the compiler starts from the scratch and always tries to resolve missing references via `MetadataReference.CreateFromFile`, thus it will be very slow. With some test cache between compilations, one of our test xaml file is improved from 18s to 3.5s.
This was referenced Jun 21, 2023
dmetzgar
reviewed
Jul 31, 2023
|
|
||
| ScriptMetadataResolver _resolver; | ||
|
|
||
| private class ResolveCacheKey |
There was a problem hiding this comment.
Can you use a record for this instead? It already has equals and hashcode implementations that do very similar things to what you're doing here.
dmetzgar
reviewed
Jul 31, 2023
| } | ||
| ConcurrentDictionary<ResolveCacheKey, ImmutableArray<PortableExecutableReference>> _resolveCache = new ConcurrentDictionary<ResolveCacheKey, ImmutableArray<PortableExecutableReference>>(); | ||
|
|
||
| private class ResolveMissingCacheKey |
There was a problem hiding this comment.
This could also be a record.
dmetzgar
reviewed
Jul 31, 2023
| _resolver = resolver; | ||
| } | ||
|
|
||
| public override bool Equals(object other) |
There was a problem hiding this comment.
Why does the resolver need this if you're always using the singleton?
dmetzgar
suggested changes
Jul 31, 2023
There was a problem hiding this comment.
Thanks for submitting this PR and apologies for the delay in reviewing. If you still want to go forward, this code seems it could be a lot simpler using records. There are enough custom hash code implementations in WF and I'd like to avoid adding another one.
aoltean16
requested changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first
Invoke()call is slow. When the xaml file contains a lot of VB scripts, JIT compiler will be used, but for every compilation, the compiler starts from the scratch and always tries to resolve missing references viaMetadataReference.CreateFromFile, thus it will be very slow. With some test cache between compilations, one of our test xaml file is improved from 18s to 3.5s.