[FLOW-15] Add middleware for CORS in localhost env #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
addison-ch
commented
Mar 21, 2024
•
addison-ch
commented
- Added custom middleware to allow CORS from localhost origins
- Added alias for chi middleware because it was conflicting with our module name 馃ゲ
addison-ch
changed the title
edwinzhng
reviewed
Mar 22, 2024
| middleware.Recoverer, | ||
| middleware.RequestID, | ||
| middleware.Timeout(10*time.Second), | ||
| middleware.CorsMiddleware(), // Enable CORS for development environments |
There was a problem hiding this comment.
Hmm I think we want to enable this only if we're running the Docker container locally - we don't want this to affect prod such that any requests coming from localhost bypass CORS
Maybe we could read in an env var for local dev and only do a Router.Use for this middleware if a dev flag is set
| import "net/http" | ||
|
|
||
| // CORS middleware for localhost environments | ||
| func CorsMiddleware() func(http.Handler) http.Handler { |
There was a problem hiding this comment.
maybe just to be explicit?
Suggested change
| func CorsMiddleware() func(http.Handler) http.Handler { | |
| func CorsLocalhostMiddleware() func(http.Handler) http.Handler { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.