recipe2016: direct expansions for Ba(II), Be(II) and Tin(II) #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No problem! That file does not have an empty blank line at the end so your software is probably adding that which is good practice. all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
True matches for recipe2016 Ba(II), Be(II) and Tin(II): Barium(II), Beryllium(II), and Tin(II), respectively. So far, those are being expanded to the elementary versions of those substances: Barium, Beryllium and Tin.
@ErCollao @ganorris
Note: every time I try to edit the file fedelemflowlist/input/mapping input/ReCiPe2016FlowableMappings.csv, the last row also gets updated and I don't understand why, nor have been able to avoid this from happening. That is why the last line also shows in the diff even though they are seemingly the same between versions. I used neovim for the edits. Sorry for this!