Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown veg_ values cause issues in albedo decay methods #215

Open
wants to merge 1 commit into
base: release-0.9
Choose a base branch
from

Conversation

micah-prime
Copy link
Contributor

…ist of strings rather than a float. Update requirements for breaking build. use_2to3 is not allowed with latest setuptools
@micah-prime
Copy link
Contributor Author

@Hedrick-ARS @jomey @scotthavens
Could you give this a look?
This first commit should show where the code breaks, then I will push the fix.

Also, does release-0.9 still build?

@@ -23,7 +23,7 @@ oset==0.1.3
pandas==0.22.0
pbr==3.1.1
progressbar2==3.6.2
pybtex==0.21
pybtex==0.24
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version 0.21 won't build with the latest setup tools due to use_2to3 being a deprecated option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this package needed and where is it used? The current version removed a lot of requirements that aren't needed.

@jomey
Copy link
Collaborator

jomey commented Nov 12, 2021

Don't have enough insights for the 0.9 release.
The code base back then also was tested against Travis and that has since changed.

What is the motivation to have this only changed in an older release?

@micah-prime
Copy link
Contributor Author

@jomey it should be fixed in the newer release as well. I can take a look at that soon. I just started with the stable version.

@scotthavens
Copy link
Contributor

We ran out of credits on Travis and they won't give us more so we moved to GH actions. This won't build anymore so you'll have to limp this along until a new release can be cut.

Let's discuss this in #214 as I don't see the reason for the fix yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants