Remove template parameter Archive from InputBindingsMap and OutputBindingsMap
#812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utBindingsMap` `Archive` isn't directly needed for any content in binding structs and required only to instantiate different global static maps for different archives. This commit turns `InputBindingsMap` and `OutputBindingsMap` into non-templated structs and modifies binding maps to include archive's typeid, such that they describe relation: `typeid(Archive) -> per-archive binding map`. That way only two global static objects will be created in runtime (for input and output bindings respectively) in each library/executable. Also types of these globals are independent from included archives and known beforehand.
|
Thank you for the rebase - the only thing holding this up and holding up most PRs is that I haven't gotten around to fixing the various CI pipelines, which inexplicably broke a while back. |
|
@arekfu Thanks for reraising this! I'm glad that finally my improvement can make it into upstream code base. |
pingelit
added a commit
to pingelit/poly-scribe
that referenced
this pull request
Feb 12, 2024
See USCiLab/cereal#812 for implementation details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rebase of #521. I am not the original author of the code in this PR (credit: @uentity), but I am willing to push it through integration.