Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unnecessary stuff if not main project #775

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LucaCiucci
Copy link
Contributor

I had some problems while including cereal in my project using FetchContent, so I made some small modifications to the CMakeLists.txt:

  • renamed some options using the CEREAL_ prefix to make clear to which project they belong to and avoid conflicts
  • changed the default value of some options so that, when not the main project, doc, sandbox and performance comparisons are disabled by default
  • added a more complete check for main project

I think this edits would make it easier to depend on cereal using FetchContent, including it as submodule or similar techniques. See this other pull request for more info.

@LucaCiucci
Copy link
Contributor Author

I see that some CI checks are not successful, but the errors are unrelated to this particular PR, am I right?

@AzothAmmo
Copy link
Contributor

Yes CI seems to be borked - was hoping to go through and slam through a bunch of these PRs but will have to fix that before I do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants