Added JSONInputArchive constructor from an already parsed rapidjson::Document #653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
And thanks for a great library!
I've got the following problem.
I'm aware that some similar (de)serializing could be done with the built-in Polymorphic Types feature, but it uses its own internal fields like "polymorphic_name" and "polymorphic_id", whose names are hardcoded, and the code around them seems not so easy to intervene and customize.
I propose to allow constructing JSONInputArchive via move-from an already parsed rapidjson::Document to fix at least the performance issues of this case: