Refactor/make code dry #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…games) and reextracted baseclass
…lerate/Decelerate/Steer)
…n error in some pointer-sockets
…yboard, gamepad or ingame-sensors like collision
…or constants _with offsets_?! That should be refactored!
|
I like this idea! I didn't look at everything now but most of it seems to make sense A lot of this code hasn't been touched in years, quite a bit of it is still left the way I initially found it I'm currently working on breaking up the basicnodes.py and other files into smaller ones in an effort to clean up the whole addon - that makes it hard to just merge a lot of this into master, so the target branch should be "refactor_files" I can look at incorporating your changes there if you don't want to do it yourself, but in any case I'd like to thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These refactorings should be api-compatible to the old version. It just makes code more dry