Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization for ease of maintenance when updating ide/make files from different OS's #185

Merged
merged 27 commits into from
Aug 27, 2023

Conversation

OldFoolAgain
Copy link
Contributor

@OldFoolAgain OldFoolAgain commented Aug 24, 2023

This contains five things:

  1. Memory patch in RC (was in my version, so sorry)
  2. Fixed two warnings under VS (cast a size_t to an int (when it was pushed into a vector, and unrefence use of a variable in a catch() statement.
  3. Renamed two files to make them match: cBaseobject.cpp -> cBaseObject.cpp , gump.h -> CGump.h (as it defines the CGump class in CGump.cpp). Associated files that included/used these files modified.
  4. This was the main focus of this update, organization. Right now, if one wants to manually update project files, and CMake files, there is no organization per se (grouping) to easily find files. So this organized CMake, and the VS2022 project/filter files to group them together. Now when one needs to update (to support cross platform developers), and have to edit those files with a text editor, there is some logical grouping.
  5. Deleted redundant workflow (build.yml)

NOTE:

  1. It was not the intention of changing groupings, if it did, it was by accident.
  2. If you change the grouping in windows, PLEASE change with an editor, not in the ide. The ide does not sort (group) on writes, so it becomes a mess. It is more effort on the windows users, but the flip side it is no more effort then any non windows developer has to do to support Windows devs.
  3. No VS2017 grouping was made, the only modification was to the two name changes to make them consistent (cbaseobject/cgump)

@OldFoolAgain
Copy link
Contributor Author

OldFoolAgain commented Aug 25, 2023

VS 2017 now modified, only to accommodate cBaseobject.cpp to cBaseObject.cpp and gump.h to CGump.h change. Also last update had a small change to cmake (position in the file, to correct grouping difference in VS). Have checked(but I am old, and miss things), that VS 2022, cmake , and Xcode match. So at least some common reference is available for developers to communicate regardless of their personal workflow for development

OldFoolAgain and others added 3 commits August 25, 2023 07:13
deleted redundant workflow (build.yml)
Re-added .md and .xcodeproj to ignore list in workflow file
Synced up VS2022 and VS2017 copies of vcxproj.filters file
Removed resource.h from VS2017 project file - file no longer exists
@Xoduz Xoduz self-requested a review August 27, 2023 18:24
@Xoduz Xoduz merged commit ef71b6f into UOX3DevTeam:feature/JS-upgrade Aug 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants