cmake updates #182
Closed
cmake updates #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added building zlib as optional quieted warnings on cmake build
|
Declining this as it was superseded by the workflow PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added building zlib as optional (macOS always has installed and built for both architectures). Unix may
or may not have it installed. Defaults to using system on macOS, and using UOX3 version on unix (and windows). One can
define SYSTEM_ZLIB on their Cmake line to use the system zlib.
quieted warnings on cmake build. Added some disabling to warnings on the Cmake build to not worry the user.