Hanging nodes constraint fix for linear problems #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the hanging dof i had a connection to dof j in the sparse matrix, but not j to i (asymmetric matrix) the constraint did not work properly.
…blems The implementation no longer distinguishes the linear from the non-linear case. Both handle the constrained nodes by effectively taking them out of the computation by making sure that the defect and corrections of constrained DoFs are always zero and their value in the solution does not change. To make this possible in the linear assembling case, the initial solution had to be introduced as an additional argument to the assembling function. ATTENTION: Unlike before, it is now necessary to call adjust_solution() once after the solver is finished to enforce the hanging node constraints in linear problems. Otherwise, the DoFs of hanging nodes will have value 0 in the solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #47.
It should be noted, that, due to the interface changes made here, minor modifications will be needed in some plugins as well.
More importantly, note the comment in the commit message:
I already have commits to update several apps and plugins.