extract_results()
: adapt use of do_scaling
option to behave as user expects.
#1345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, even when the user specifies
do_scaling=False
inextract_results
, there is an attempt to scale results (by 1.0). This causes unexpected errrors in the case of non-numeric data.This update means that when
do_scaling=False
there is no attemt to any scaling and so the function can be used safely with non-numeric data.