Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run clang-format 17.0.0 as opposed to 14.0.0. See #1376. 118 files changed (!)
A few more comments
//
, convention used for pure virtualsAllowShortFunctionsOnASingleLine: InlineOnly
(14.0.0 bug [clang-format] "AllowShortFunctionsOnASingleLine: Inline" doesn't works after a "#pragma" directive llvm/llvm-project#55260). I guess we could switch that option to off.#if 0 ... #else #endif
stuff (seems to ignore all of it, and therefore ends up with wrong formatting)Anway, it's a mess.