Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilt plot_sinogram_profiles.py for 4D tof data #1370

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

robbietuk
Copy link
Collaborator

Changes in this pull request

Built plot_projdata_profiles.py to replace plot_sinogram_profiles.py. This allows for TOF data to be handled. I added significant error handling and what I hope is a better user experience. It does break backwards compatabity.

I need to add a the ability to read v6.0 STIR projection data.

Testing performed

Include a pytest (commented out)

Related issues

#1363

Checklist before requesting a review

  • [] I have performed a self-review of my code
  • [] I have added docstrings/doxygen in line with the guidance in the developer guide
  • [] I have implemented unit tests that cover any new or modified functionality (if applicable)
  • [] The code builds and runs on my machine
  • [] documentation/release_XXX.md has been updated with any functionality change (if applicable)

@robbietuk robbietuk added this to the v6.0 milestone Feb 5, 2024
@robbietuk robbietuk self-assigned this Feb 5, 2024
Copy link
Collaborator Author

@robbietuk robbietuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few usage observations

examples/python/plot_projdata_profiles.py Show resolved Hide resolved
examples/python/plot_projdata_profiles.py Outdated Show resolved Hide resolved
@KrisThielemans KrisThielemans modified the milestones: v6.0, v6.1 Feb 7, 2024
Copy link
Collaborator

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this and would be ok to merge (after an update to release_6.1.htm)

examples/python/plot_projdata_profiles.py Show resolved Hide resolved
examples/python/plot_projdata_profiles.py Outdated Show resolved Hide resolved
import numpy as np
import pytest

from examples.python.plot_projdata_profiles import compress_and_extract_1d_from_nd_array
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pytest fails, it will likely be here. This worked on my debugger but failed on my CLI, it was probably an enviroment issue.

@KrisThielemans
Copy link
Collaborator

pytest fails with

ModuleNotFoundError: No module named 'examples'

Could be solved by adding it to the pythonpath first (would need to be done both for GHA and AppVeyor). Alternatively, we do it better via #1392

@KrisThielemans KrisThielemans modified the milestones: v6.1, v6.2 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants