Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made isolatedModules always false #18

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Made isolatedModules always false #18

merged 1 commit into from
Jun 7, 2017

Conversation

johnnyreilly
Copy link
Member

so it can be set to true in the tsconfig.json without affecting typechecking. I think it's as simple as this - do correct me if I'm wrong!

Resolves #17

BTW your build is *nix specific (the NODE_ENV=test in the package.json). I haven't changed it but you could make it cross platform easily with cross-env

@piotr-oles piotr-oles merged commit 3303765 into TypeStrong:master Jun 7, 2017
@piotr-oles
Copy link
Collaborator

Well done, thank you for your work :)

I will add cross-env but not sure when - currently I'm a little bit busy :/

@johnnyreilly
Copy link
Member Author

currently I'm a little bit busy :/

Believe me I understand 😄 BTW I've started the blog post - about half written so far. I'm planning to do one post that first covers using fork-ts-checker-webpack-plugin and then moves on to add happypack into the mix as well. (again using fork-ts-checker-webpack-plugin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants