Renamed noInitJustStart to start

TypeFox · Nov 26, 2023 · 1b3c6cf · 1b3c6cf
1 parent 43bd86d
commit 1b3c6cf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/monaco-editor-react/src/index.tsx b/packages/monaco-editor-react/src/index.tsx
@@ -140,7 +140,7 @@ export class MonacoEditorReactComp<T extends MonacoEditorProps = MonacoEditorPro
         if (this.containerElement) {
             this.containerElement.className = className ?? '';
 
-            await this.wrapper.noInitJustStart(this.containerElement);
+            await this.wrapper.start(this.containerElement);
             this.started();
             this.isRestarting = undefined;
 

diff --git a/packages/monaco-editor-wrapper/src/wrapper.ts b/packages/monaco-editor-wrapper/src/wrapper.ts
@@ -92,15 +92,15 @@ export class MonacoEditorLanguageClientWrapper {
      */
     async initAndStart(userConfig: UserConfig, htmlElement: HTMLElement | null) {
         await this.init(userConfig);
-        await this.noInitJustStart(htmlElement);
+        await this.start(htmlElement);
     }
 
     /**
      * Does not perform any user configuration or other application init and just starts the application.
      */
-    async noInitJustStart(htmlElement: HTMLElement | null) {
+    async start(htmlElement: HTMLElement | null) {
         if (!this.initDone) {
-            throw new Error('No init was performed. Please call init() before noInitJustStart()');
+            throw new Error('No init was performed. Please call init() before start()');
         }
         if (!htmlElement) {
             throw new Error('No HTMLElement provided for monaco-editor.');

diff --git a/packages/monaco-editor-wrapper/test/wrapper.test.ts b/packages/monaco-editor-wrapper/test/wrapper.test.ts
@@ -42,8 +42,8 @@ describe('Test MonacoEditorLanguageClientWrapper', () => {
         createMonacoEditorDiv();
         const wrapper = new MonacoEditorLanguageClientWrapper();
         await expect(async () => {
-            await wrapper.noInitJustStart(document.getElementById('monaco-editor-root'));
-        }).rejects.toThrowError('No init was performed. Please call init() before noInitJustStart()');
+            await wrapper.start(document.getElementById('monaco-editor-root'));
+        }).rejects.toThrowError('No init was performed. Please call init() before start()');
     });
 
     test('Expected throw: Call normal start with prior init', async () => {