Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the path to the value of the tib service port #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codingWombat
Copy link

@codingWombat codingWombat commented Mar 11, 2024

Description

Fixed a the value used for the stand alone tib ingress route, as here the value of the dashboard is used.

  • Setup standalone tib and try use it.
  • you will get timeouts as the the wrong service port is used

Related Issue

#301

Motivation and Context

Makes the stand alone tib usable

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codingWombat codingWombat requested a review from a team as a code owner March 11, 2024 08:34
@codingWombat codingWombat requested review from olamilekan000 and removed request for a team March 11, 2024 08:34
Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @codingWombat for the contribution. i'll move this ticket for internal testing. once it is done, it'll be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants