Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the name simplification algorithm #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JonasAlaif
Copy link
Contributor

The current algorithm will create confusing names in the case of a clash. For example given the two names box_123 and box_222 it will simplify these to b and bo - it is unclear which of these corresponds to 123 and which to 222. The updated algorithm is more symmetric in that it finds the least common prefix required to differentiate between these two, in the example this would be box_1 and box_2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant