Update ADVI interface to match AdvancedVI.jl
#2068
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the internals of
Turing
to match the rebootedAdvancedVI.jl
.Breaking? Changes
The only change from the previous interface is that I propose to move the number of iterations from
ADVI
tovi
.That is, change
to
This is more consistent with the MCMC interface
sample
where the number of samples is supplied tosample
notNUTS
.Dependencies
This currently depends on
Turing
to theADTypes
interface in this PR.