Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to geojsonhint and geojson-fixtures #2571

Merged
merged 3 commits into from Jan 17, 2024

Conversation

mfedderly
Copy link
Collaborator

@mfedderly mfedderly commented Jan 17, 2024

There were transitively bringing in a weird dependency to a specific git commit of gerhobbelt/nomnom and was breaking CI for dependabot.

There were transitively bringing in a weird dependency to a specific git commit of gerhobbelt/nomnom and was breaking CI for dependabot.
Object.keys(fixtures).forEach((name) => {
writeJsonFileSync(directories.in + name + ".json", fixtures[name]);
});
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only referenced the geojson-fixtures package to regenerate the inputs into the tests, so we already have what we need here.

Copy link
Member

@smallsaucepan smallsaucepan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straight forward 👍

@mfedderly mfedderly merged commit 08576cb into master Jan 17, 2024
3 checks passed
@mfedderly mfedderly deleted the mf/remove-geojsonhint branch January 17, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants