Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with prerelease builds #2562

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Fix issues with prerelease builds #2562

merged 1 commit into from
Dec 30, 2023

Conversation

mfedderly
Copy link
Collaborator

  • Added a fetch-depth: 0 config that should give us the git history and correctly calculate the canary versions
  • Don't run scripts as part of the lerna release step, they were already run by the github actions steps
  • Fix issue with reference to the node 'util' package that was preventing the browser version of @turf/turf from working

I think that the undefined references from the previous attempt are being caused by the root package.json not having a version. I think that's fine though?

- Added a fetch-depth: 0 config that should give us the git history and correctly calculate the canary versions
- Don't run scripts as part of the lerna release step, they were already run by the github actions steps
- Fix issue with reference to the node 'util' package that was preventing the browser version of @turf/turf from working
Copy link
Collaborator

@twelch twelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think no version at root level is fine. Not sure if lerna would care if you did add one

@mfedderly mfedderly merged commit 1411d63 into master Dec 30, 2023
3 checks passed
@mfedderly mfedderly deleted the mf/releases-try-two branch December 30, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants