Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node 12 and add in node 18 and 20 to CI build matrix #2430

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Remove node 12 and add in node 18 and 20 to CI build matrix #2430

merged 2 commits into from
Apr 30, 2023

Conversation

JamesLMilner
Copy link
Collaborator

@JamesLMilner JamesLMilner commented Apr 29, 2023 •
edited

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

Here we remove node 12 and add in node 18 and 20 into the CI build matrix. Node 12 is end of life.

Resolves #2417

@rowanwins rowanwins self-requested a review April 30, 2023 08:30
rowanwins
rowanwins approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@rowanwins rowanwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JamesLMilner JamesLMilner merged commit 44d2ca2 into Turfjs:master Apr 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowanwins rowanwins rowanwins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 12 is End of Life
2 participants
@JamesLMilner @rowanwins