optimize ring area calculation #1387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unwind special (n - 2 and n - 1) cases to simplify the loop - keep track lower, middle, and upper value in radians so that we don't need to recalculate them while traversing the ring bench before: polygon x 4,280,634 ops/sec ±1.53% (89 runs sampled) bench after: polygon x 5,810,796 ops/sec ±1.09% (87 runs sampled)
|
Hi @pirxpilot Sorry its taken a long time for someone to review this. Looking at the Travis test result the change to this module is causing issues in I'll need to do a bit more in-depth testing on isobands to make sure it's all working out as expected. |
AminoffZ
added a commit
to AminoffZ/turf
that referenced
this pull request
Oct 22, 2023
twelch
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Merge pull request #1387 from pirxpilot:area * Fix optimized ringArea * Regen nearest-neighbor-analysis * Add rest of out tests * update turf-area benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bench before: polygon x 4,280,634 ops/sec ±1.53% (89 runs sampled)
bench after: polygon x 5,810,796 ops/sec ±1.09% (87 runs sampled)