Chore(2523): Improve logging, primarily on desktop #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikoenigsknecht
changed the title
|
Resolves #2523 |
adrastaea
reviewed
May 13, 2024
adrastaea
approved these changes
May 15, 2024
ikoenigsknecht
commented
May 15, 2024
| @@ -0,0 +1,20 @@ | |||
| import { shouldPolyfill as shouldPolyfillCanon } from '@formatjs/intl-getcanonicallocales/should-polyfill' | |||
There was a problem hiding this comment.
I'm not sure if this is the best place for this polyfill. I wanted it to be in mobile since its specific to mobile but the mobile code wasn't being run soon enough, it seems, to run before the logging started.
There was a problem hiding this comment.
I also added some doc strings to the this file for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuietLoggerclass with improved formatting and colorizationPull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: