Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add base class for Stores #2493

Merged
merged 12 commits into from May 16, 2024
Merged

refactor: add base class for Stores #2493

merged 12 commits into from May 16, 2024

Conversation

EmiM
Copy link
Collaborator

@EmiM EmiM commented Apr 29, 2024 •
edited

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

adrastaea
adrastaea approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@adrastaea adrastaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions, nitpicks, but looks like a great improvement to me!

packages/backend/src/nest/common/types.ts Show resolved Hide resolved
packages/backend/src/nest/storage/storage.service.ts Show resolved Hide resolved
@adrastaea
Copy link
Collaborator

Just noticed the changelog needs updated though

@EmiM EmiM mentioned this pull request May 10, 2024
Open
ikoenigsknecht
ikoenigsknecht approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@ikoenigsknecht ikoenigsknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

@EmiM EmiM merged commit 5c5d9c8 into develop May 16, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmesworcester holmesworcester holmesworcester left review comments

@leblowl leblowl leblowl left review comments

@ikoenigsknecht ikoenigsknecht ikoenigsknecht approved these changes

@adrastaea adrastaea adrastaea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@EmiM @adrastaea @holmesworcester @leblowl @ikoenigsknecht