[WIP] ActivityPub tests & following #20206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allouis
force-pushed
the
activitypub-rebasing
branch
from
01a1174
to
c34f80e
Compare
ref https://linear.app/tryghost/issue/MOM-73 We need to add body parsing middleware here, so that NestJS has access to it. We also attach the rawBody which is used to validate the HTTP Signatures
ref https://linear.app/tryghost/issue/MOM-73 We've made it easier to use by adding defaults for required header, as well as adding support for signing POST requests.
ref https://linear.app/tryghost/issue/MOM-120 We need to do this to lookup the inbox which we need to send a Follow activity
ref https://linear.app/tryghost/issue/MOM-120 This will allow us to deliver Follow activities to other sites
The supertest lib is the officially recommended way of testing NestJS e2e
With TypeScript, when creating mock instances, it's preferable to maintain a reference to the params, even if they're not used. This allows us to have unused variables as long as they're prefixed with an underscore.
ref https://linear.app/tryghost/issue/MOM-108 Apologies to my future self and maintainers if you come across this commit. This is a bit of a mega commit because we need to cut corners somewhere and it came down to commit atomicity or tests/code quality. The main changes here are a bunch of tests, as well as some scaffolding for Inbox handling of Activities and delivery of Activities. The structure is not final at all - and we have logic split across services which isn't ideal - but thsi will do for now as we play around and discover the structure through building.
allouis
force-pushed
the
activitypub-rebasing
branch
from
c34f80e
to
35c16cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃崷