Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve messaging and error handling #20078

Merged
merged 19 commits into from May 14, 2024
Merged

Improve messaging and error handling #20078

merged 19 commits into from May 14, 2024

Commits on May 14, 2024

  1. Updated basic toast style

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d0f896c View commit details
    Browse the repository at this point in the history

  2. Updated toast shadow and animation style

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3a9e668 View commit details
    Browse the repository at this point in the history

  3. Updated integration save errors

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    12776f6 View commit details
    Browse the repository at this point in the history

  4. Updated toast messages in Settings 

    - Toast messages in Settings were too generic, ie. not tailored for the given experience. This commit removes all unnecessary toasts and updates the messages to make more sense, be more consise and consistent with Ghost wording.
    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    2a47d55 View commit details
    Browse the repository at this point in the history

  5. Toast style refinements

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f59d6c0 View commit details
    Browse the repository at this point in the history

  6. Remove page level error from Portal

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    eb0fa59 View commit details
    Browse the repository at this point in the history

  7. Updated toast style outside Settings

    @minimaluminium @peterzimon
    minimaluminium authored and peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6b42cc5 View commit details
    Browse the repository at this point in the history

  8. Spacing adjustment

    @minimaluminium @peterzimon
    minimaluminium authored and peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0176c7d View commit details
    Browse the repository at this point in the history

  9. Fixed tests

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    a653d4c View commit details
    Browse the repository at this point in the history

  10. Consolidated toaster styles

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    97ba8c8 View commit details
    Browse the repository at this point in the history

  11. Removed error toasts

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b0b53fd View commit details
    Browse the repository at this point in the history

  12. Updated OK button behavior when saving 

    Instead of using toast to let people know about fields with error in a form, we show a "Retry" button. This aligns with the pattern we use elsewhere in Ghost and makes the UI less cluttered.
    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f3addae View commit details
    Browse the repository at this point in the history

  13. Fixed error bugs

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    1c22537 View commit details
    Browse the repository at this point in the history

  14. Updated notification style

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    bf09711 View commit details
    Browse the repository at this point in the history

  15. Refined style

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    630a1e4 View commit details
    Browse the repository at this point in the history

  16. Dark mode refinements

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ce51b90 View commit details
    Browse the repository at this point in the history

  17. Fix tests

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    bf17387 View commit details
    Browse the repository at this point in the history

  18. Fixed publication lang. empty error

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e693c71 View commit details
    Browse the repository at this point in the history

  19. Removed 'successfully' from notifications

    @peterzimon
    peterzimon committed May 14, 2024
    Configuration menu
    Copy the full SHA
    de1427f View commit details
    Browse the repository at this point in the history