Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when running yarn dev on Windows 11 #17705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shaunroselt
Copy link
Contributor

@shaunroselt shaunroselt commented Aug 13, 2023

This fixes ERROR Unable to activate the theme "casper". and Unable to activate the theme "casper". when running yarn dev on Windows 11 mentioned on this issue: #17704

This commit doesn't fix the entire issue, but it fixes the first part of the issue. It's also only tested on my Windows 11 system. Someone just needs to test it on MacOS and make sure it's working there too, but I'm 99% sure it won't cause any issues on MacOS and will just work as always.

Got some code for us? Awesome 馃帄!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!


馃 Generated by Copilot at 47a7921

Fix admin panel loading bug by ensuring destination directory for index.html exists. Refactor AdminAuthAssetsService.js to use variables for paths.

This fixea `ERROR Unable to activate the theme "casper".` and `Unable to activate the theme "casper".` when running `yarn dev` on Windows 11.
@shaunroselt
Copy link
Contributor Author

Just for some added info here. For some reason on Windows 11, it kept failing on fs.copyFile because the FileDestination directories didn't exist. On MacOS, it probably created the directories if it doesn't exist with the fs.copyFile function, but on my Windows 11 Build, this didn't happen. So it kept failing.

Thus, I just needed to add fs.mkdir before fs.copyFile and actually create the directories before trying to copy to them.

So now, this error won't happen anymore on Windows 11:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant