Add logout button to burger menu in mobile

[martinvarelaaaa]

Issue #281

• The logout button is added to the burger menu in the mobile version
• A logout function is added in auth-helpers to reuse the code

Execution:
https://drive.google.com/file/d/1gxiU00UBtjd-h2ktnGNybLqE1KLI9y8x/view

[thkruz]

Is "logoutCallback" a misnomer since it is never passed as a callback function?

[martinvarelaaaa]

Is "logoutCallback" a misnomer since it is never passed as a callback function?

Ok @thkruz What name do you propose?

[thkruz]

@martinvarelaaaa was a genuine question. "closeAndLogout" sounds more intuitive to me if it isn't a callback, but I was mainly just concerned I misunderstood the code (react is a bit confusing to me).

[martinvarelaaaa]

Done @thkruz !

[johngribbin]

@martinvarelaaaa Thanks for this Martín, ill review asap - probably tomorrow.

[johngribbin]

@martinvarelaaaa Great work Martín, and thanks for the input @thkruz

The code and functionality looks good to me, but I think we can make one small tweak to ensure that whenever the user "logs out" using the burger menu, they always get kicked back to the "home page." This is the user-experience that is currently in place when a user logs out via the AccountSettings page, and it would be cool to ensure that this is replicated by the burger menu log out.

If you check AccountSettings component you will see an import entitled withRouter from react-router-dom. This helper allows any component to avail of the routers history object - so that a push to a different route can occur within the component. To use history within the component you have to pass it to the withRouter helper at the bottom of the file when exporting it.

Like so:

export default withRouter(UserSettings);

And then you can access it via the de-structuring syntax like so:

function UserSettings({ history }) {
...
}

Note - this would mean that your check for the history helper inside the logoutAndClose function would now be redundant - as both components would have access to the routers history.

If you can push those couple of tweaks, ill merge and deploy.

Hope my notes make sense to you. Any problems or questions just let me know.

Thanks!
John.

[martinvarelaaaa]

Ok perfect @johngribbin! I'll probably turn up the fix tomorrow