Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject non-ascii values in Manta Headers #395

Closed
dekobon opened this issue Jan 2, 2018 · 3 comments · May be fixed by #576
Closed

Reject non-ascii values in Manta Headers #395

dekobon opened this issue Jan 2, 2018 · 3 comments · May be fixed by #576
Assignees
@indianwhocodes

Comments

@dekobon
Copy link
Contributor

dekobon commented Jan 2, 2018

Due to MANTA-3527, objects can go into a state where they cannot be read if the header was written with a non-ascii value. We should add a guard clause that tells users that a non-ascii value was invalid and guide them to encode it.
@tjcelaya
Copy link
Contributor

tjcelaya commented Jan 3, 2018

tells users that a non-ascii value was invalid and guide them to encode it.

Just to be clear we want to throw an exception since this effectively makes the object inaccessible right? The ticket description implies this could be fixed server-side by a node.js update but I presume we would want to entirely forbid people from getting themselves into this situation.

@tjcelaya
Copy link
Contributor

tjcelaya commented Jan 3, 2018

Also, "Manta Headers" -> "Metadata" ?

@dekobon
Copy link
Contributor Author

dekobon commented Jan 4, 2018

Just to be clear we want to throw an exception since this effectively makes the object inaccessible right? The ticket description implies this could be fixed server-side by a node.js update but I presume we would want to entirely forbid people from getting themselves into this situation.

Yes, we want to forbid them. Additionally, we want to suggest to them to encode the data in someway that makes it 7-bit safe. Like UUENCode, URLEncode or mime64.

Also, "Manta Headers" -> "Metadata" ?

Yes.

tjcelaya added a commit to tjcelaya/java-manta that referenced this issue Jan 6, 2018
@tjcelaya
Resolve TritonDataCenter#395 for metadata. Still need to determine if…
f224d4d 
… MantaHttpHeaders should do this as well (and if so extract HttpHeaderPredicate)
tjcelaya added a commit to tjcelaya/java-manta that referenced this issue Jan 8, 2018
@tjcelaya
Resolve TritonDataCenter#395 for metadata. Still need to determine if…
a3ca100 
… MantaHttpHeaders should do this as well (and if so extract HttpHeaderPredicate)
@dekobon dekobon closed this as completed Jan 18, 2019
@indianwhocodes indianwhocodes self-assigned this May 5, 2020
@indianwhocodes indianwhocodes mentioned this issue May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indianwhocodes indianwhocodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #395
3 participants
@dekobon @tjcelaya @indianwhocodes