Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate behavior of manta.skip_directory_depth greater than depth of directory to be created #414

Open
tjcelaya opened this issue Apr 25, 2018 · 0 comments
Assignees

Comments

@tjcelaya
Copy link
Contributor

Currently users can attempt to skip a fixed number of directory creation steps when utilizing the recursive option to MantaClient#putDirectory. As a precaution the initial implementation of this feature reverted to the standard behavior when the setting was tuned too high, e.g. creating /user/stor/foo/bar/baz with the setting at 10 would create all parts (.../foo, .../foo/bar, .../foo/bar/baz).

We can improve this slightly be treating the writeableDirectories <= skipDepth case as "try to create the requested directory directly, then fall back to creating all parts if that fails." Effectively, turning the setting up to a ridiculous number would cause recursive putDirectory calls to behave as if every intermediate directory already existed.

More clearly phrased, if we set manta.skip_directory_depth to 100 any attempts to create recursively directories with less than 100 segments will begin by attempting to create just the requested path (falling back to creating all intermediate directories if that fails).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants